feat: make configurable max_fee_estimation_tolerance in call handlers#1667
Open
grandima wants to merge 1 commit intoFuelLabs:masterfrom
Open
feat: make configurable max_fee_estimation_tolerance in call handlers#1667grandima wants to merge 1 commit intoFuelLabs:masterfrom
grandima wants to merge 1 commit intoFuelLabs:masterfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @grandima to sign the Fuel Labs Contributor License Agreement. |
a0f4976 to
323c2d7
Compare
… and Executable APIs
323c2d7 to
e0c5d84
Compare
Author
|
@segfault-magnet please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1591
Release notes
In this release, we:
CallHandler,TransactionTunerandExecutableChecklist
Note
Adds a configurable
max_fee_estimation_toleranceacross call handlers, transaction builders, and loader blob uploads, with tests.CallHandler:max_fee_estimation_tolerancewith builderwith_max_fee_estimation_tolerance(...).transaction_builder_with_parametersand builder creation.TransactionTuner(trait and impls):transaction_builder(...)signature to acceptmax_fee_estimation_tolerance: f32.ScriptCall/ContractCall/Vec<ContractCall>pass tolerance toScriptTransactionBuilder.with_max_fee_estimation_tolerance(...).calls/utils.rs:transaction_builder_from_contract_calls(...)now takes tolerance and forwards it to the builder.upload_blob_with_tolerance(account, max_fee_estimation_tolerance);upload_blobdelegates to it.BlobTransactionBuilder.with_max_fee_estimation_tolerance(...).test_max_fee_estimation_toleranceine2e/tests/contracts.rsvalidating default and custom tolerances.Written by Cursor Bugbot for commit e0c5d84. This will update automatically on new commits. Configure here.